Hi Pekka,
> ---
> src/main.c | 12 ++++++------
> src/ofono.h | 2 +-
> src/plugin.c | 28 ++++++++++++++++++----------
> 3 files changed, 25 insertions(+), 17 deletions(-)
>
> diff --git a/src/main.c b/src/main.c
> index 20bf0d7..9cf32eb 100644
> --- a/src/main.c
> +++ b/src/main.c
> @@ -93,8 +93,8 @@ static void system_bus_disconnected(DBusConnection *conn,
> void *user_data)
> }
>
> static gchar *option_debug = NULL;
> -static gchar *option_plugin = NULL;
> -static gchar *option_noplugin = NULL;
> +static gchar **option_plugin;
> +static gchar **option_noplugin;
> static gboolean option_detach = TRUE;
> static gboolean option_version = FALSE;
>
> @@ -113,9 +113,9 @@ static GOptionEntry options[] = {
> { "debug", 'd', G_OPTION_FLAG_OPTIONAL_ARG,
> G_OPTION_ARG_CALLBACK, parse_debug,
> "Specify debug options to enable", "DEBUG" },
> - { "plugin", 'p', 0, G_OPTION_ARG_STRING, &option_plugin,
> + { "plugin", 'p', 0, G_OPTION_ARG_STRING_ARRAY, &option_plugin,
> "Specify plugins to load", "NAME" },
> - { "noplugin", 'P', 0, G_OPTION_ARG_STRING, &option_noplugin,
> + { "noplugin", 'P', 0, G_OPTION_ARG_STRING_ARRAY, &option_noplugin,
> "Specify plugins not to load", "NAME" },
> { "nodetach", 'n', G_OPTION_FLAG_REVERSE,
> G_OPTION_ARG_NONE, &option_detach,
in general I am fine with this, but we need to be a bit more consistent
across projects and across options here.
So if we do it like this then we have to also make this work for ConnMan
and then also the --debug option should be able to handle multiple
options. Besides the magic of separating via : and , which is already
supported and documented there.
Regards
Marcel
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
