Hi Jeevaka,
>-----Original Message----- >From: [email protected] [mailto:[email protected]] On Behalf Of >[email protected] >Sent: Wednesday, September 22, 2010 3:29 AM >To: [email protected] >Subject: RE: [PATCH 5/5] cf: Handle send ss proactive command > >Hi Yang, > >> --- a/src/stk.c >> +++ b/src/stk.c > >> + unsigned char addnl[2]; >> + >> + default: >> + DBG("Send ss finishes with error type: %d", >error->type); >> + rsp.result.type = STK_RESULT_TYPE_SS_RETURN_ERROR; >> + addnl[0] = (unsigned char) error->error; >> + addnl[1] = STK_RESULT_ADDNL_SS_PB_NO_SPECIFIC_CAUSE; >> + rsp.result.additional = addnl; >> + rsp.result.additional_len = 2; >> + break; >> + } >> + > >Isn't the above code, has to be something like > > unsigned char addnl; > > default: > rsp.result.type = STK_RESULT_TYPE_SS_RETURN_ERROR; > addnl = STK_RESULT_ADDNL_SS_PB_NO_SPECIFIC_CAUSE; > rsp.result.additional = &addnl; > rsp.result.additional_len = 1; You are right and I will change the code following this. Thanks for the comment! Regards, -Yang _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
