Hi Denis,
> I really don't want to argue about this.
>
> SetProperty("TechnologyPreference", ..)
> -> Sets RADIO_SETTINGS_MODE_CACHED
>
> GetProperties() -> queries Fast dormancy
> GetProperties() -> queries Fast dormancy
> ->
>
> + } else if (rs->driver->query_fast_dormancy) {
> + rs->driver->query_fast_dormancy(rs,
> +
> fast_dormancy_query_callback, rs);
> + dbus_message_unref(reply);
> + return NULL;
> + }
> +
>
> You never set pending in the FastDormancy case.
Good catch. That's a bug, of course. Doesn't invalidate the approach, though.
> > Understandable. Makes it difficult to improve on design
> patterns that have already been replicated, though.
> >
>
> Nobody is against improving things, but please try to do it in the
> appropriate forum. E.g. and RFC to the mailing list or an
> IRC discussion.
Of course. This time I wasn't conciously trying to improve things, though.
Anyway, enough yakking. I'll do the rewrite sicne you're adamant.
Br,
MikaL
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
