Hi Jeevaka,

On 11/26/2010 08:57 AM, Jeevaka Badrappan wrote:
> ---
>  src/call-volume.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/src/call-volume.c b/src/call-volume.c
> index dd1be92..0accdf2 100644
> --- a/src/call-volume.c
> +++ b/src/call-volume.c
> @@ -114,7 +114,6 @@ static DBusMessage *cv_get_properties(DBusConnection 
> *conn,
>       dbus_bool_t muted;
>  
>       reply = dbus_message_new_method_return(msg);
> -
>       if (!reply)
>               return NULL;
>  

Style wise this is actually OK, but if you really want to be
style-pedantic :) then this should be:

reply = ...
if (reply == NULL)
        return NULL

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to