Hi Guillaume,

On 25 November 2010 09:44, Lucas, GuillaumeX <[email protected]> wrote:
> From: Guillaume Lucas <[email protected]>
>
> According to the sequence 1.2 of the ETSI TS 102 384 a busy
> screen error type must be returned for the display text
> proactive command when the message is not urgent and if the
> ME is not able to display the text.
> ---
>  doc/stk-api.txt |    1 +
>  src/stk.c       |    7 +++++++
>  src/stkagent.c  |   12 ++++++++++--
>  src/stkagent.h  |    1 +
>  4 files changed, 19 insertions(+), 2 deletions(-)
>
> diff --git a/doc/stk-api.txt b/doc/stk-api.txt
> index b9ca592..79daee6 100644
> --- a/doc/stk-api.txt
> +++ b/doc/stk-api.txt
> @@ -116,6 +116,7 @@ Methods             byte RequestSelection(string title, 
> byte icon_id,
>                        cleared prior to the display of this text.
>
>                        Possible Errors: [service].Error.SimToolkit.GoBack
> +                                        [service].Error.SimToolkit.Busy
>
>                        Implementation notes:
>
> diff --git a/src/stk.c b/src/stk.c
> index ac2e646..e6b78a4 100644
> --- a/src/stk.c
> +++ b/src/stk.c
> @@ -1250,6 +1250,10 @@ static void display_text_cb(enum stk_agent_result 
> result, void *user_data)
>                        STK_RESULT_TYPE_NO_RESPONSE : STK_RESULT_TYPE_SUCCESS);
>                break;
>
> +       case STK_AGENT_RESULT_BUSY:
> +               send_simple_response(stk, STK_RESULT_TYPE_TERMINAL_BUSY);
> +               break;
> +

According to TS 102.223 on Screen Busy we also need to append a
"additional info" field in the Terminal Busy response with a 1-byte
value 01 ("screen is busy").

Denis on IRC also wondered if this response should be allowed when the
message is flagged urgent.

>        case STK_AGENT_RESULT_TERMINATE:
>        default:
>                send_simple_response(stk, STK_RESULT_TYPE_USER_TERMINATED);
> @@ -1363,6 +1367,7 @@ static void request_confirmation_cb(enum 
> stk_agent_result result,
>                break;
>
>        case STK_AGENT_RESULT_TERMINATE:
> +       default:
>                send_simple_response(stk, STK_RESULT_TYPE_USER_TERMINATED);
>                break;

Most of the other commands also allow a "Terminal busy" response in
table 6.1 in section 6.11, without giving a specific "additional info"
value.  I think it would be ok to treat them the same way as
DisplayText and supply the "screen is busy" value, what do you think?

Best regards
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to