Hi Gustavo,
> @@ -488,16 +465,18 @@ static void online_cb(const struct ofono_error *error,
> void *data)
> DBusMessage *reply;
>
> if (error->type == OFONO_ERROR_TYPE_NO_ERROR &&
> - modem->modem_state == MODEM_STATE_OFFLINE)
> + modem->modem_state == MODEM_STATE_OFFLINE) {
> + modem_change_state(modem, MODEM_STATE_ONLINE);
> +
> + if (!modem->pending)
> + return;
> +
Fair enough...
> reply = dbus_message_new_method_return(modem->pending);
> - else
> + } else {
> reply = __ofono_error_failed(modem->pending);
But what about the error case?
> + }
>
> __ofono_dbus_pending_reply(&modem->pending, reply);
> -
> - if (error->type == OFONO_ERROR_TYPE_NO_ERROR &&
> - modem->modem_state == MODEM_STATE_OFFLINE)
> - modem_change_state(modem, MODEM_STATE_ONLINE);
> }
>
> static void offline_cb(const struct ofono_error *error, void *data)
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
