On 12/08/2010 06:35 PM, Lei Yu wrote:
> ---
>  Makefile.am                    |    7 ++
>  configure.ac                   |    5 ++
>  drivers/cdma-atmodem/atmodem.c |   47 ++++++++++++
>  drivers/cdma-atmodem/atmodem.h |   23 ++++++

You need to synchronize with Dara on this one.  Both of you are sending
the same stub implementation.  I suggest submitting this as a separate
patch.  And please name it cdmamodem/cdmamodem.c & .h.  Dara has this
right actually.

>  drivers/cdma-atmodem/atutil.c  |   45 ++++++++++++
>  drivers/cdma-atmodem/atutil.h  |   64 +++++++++++++++++

As I mentioned before, please use the atutil.[ch] from atmodem directly.
 No need to create a new set of these...

>  drivers/cdma-atmodem/sms.c     |  151 
> ++++++++++++++++++++++++++++++++++++++++

And this one should be in a separate patch ;)

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to