Hi Jun,

On Tue, 2010-12-28 at 18:00 +0800, ext Wei, Jun wrote:
> Hi Antti,
> 
> >+static GSList *g_drivers = NULL;
> >+
> >+static GDBusMethodTable ci_methods[] = {
> >+    { "GetProperties",      "",     "a{sv}aa{sv}",  ci_get_cells },
> >+    { }
> +};
> +
> 
> Do we need to add 'G_DBUS_METHOD_FLAG_ASYNC' after ci_get_cells? 

Yes, we need. Already noticed it myself while testing :). I'll post the
next version of the patch soon which contains all sort of fixes plus
refactoring. 

> 
> >+static DBusMessage *ci_get_cells(DBusConnection *conn, DBusMessage *msg,
> >+                                    void *data)
> >+{
> >+    struct ofono_cell_info *ci = data;
> >+    DBG("");
> >+
> >+    ci->pending = dbus_message_ref(msg);
> >+    ci->driver->query(ci, ofono_cell_info_query_cb, ci->driver_data);
> 
> The 3rd parameter should be 'ci' instead of 'ci->driver_data', right?

Well, the first parameter is already 'ci', so maybe repetition is not
needed. The third parameter is kind of useless here anyway.

Thanks for the comments.

Best Regards,
  Antti

_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to