Hi Denis, On Tue, Jan 4, 2011 at 3:13 PM, Denis Kenzior <[email protected]> wrote: > Hi Lucas, > > On 01/04/2011 07:06 AM, Lucas De Marchi wrote: >> @@ -62,6 +62,8 @@ struct ofono_sim { >> enum ofono_sim_password_type pin_type; >> gboolean locked_pins[OFONO_SIM_PASSWORD_SIM_PUK]; /* Number of PINs */ >> >> + GSList *pin_retries; >> + > > Are you forgetting to free the pin_retries array when the sim is removed > or the sim atom is destroyed? >
Yes, I forgot. Since I cannot have G* types on headers, I'll store a ofono_sim_pin_retry **retries here and convert the code so the list will not be necessary. Is this ok? > The rest seems fine to me. > thanks regards, Lucas De Marchi _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
