Hi Jun,
On Thu, 2011-01-06 at 20:35 +0800, ext Wei, Jun wrote:
> Hi Antti,
>
> >-----Original Message-----
> >Subject: [PATCH 3/5 v2] Cell-info: Atom for obtaining ECID info of cells
> >
> >+static int append_utra_neigh_cell_data(DBusMessageIter *iter,
> >+ struct cell_measured_results *cmr)
> >+{
> >
> >
> >+
> >+ if (cmr->rscp != OFONO_CI_FIELD_RSCP_UNDEFINED)
> >+ ofono_dbus_dict_append(iter,
> >+ "CPICH-RSCP",
> >+ DBUS_TYPE_INT16,
> >+ &cmr->rscp);
> >+
>
> The type for RSCP should be "DBUS_TYPE_BYTE"
RSCP may obtain negative values whereas DBUS_TYPE_BYTE is a
type code marking an 8-bit _unsigned_ integer.
-Antti
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
