On Friday 07 January 2011 18:25:32 ext Denis Kenzior, you wrote:
> > @@ -2001,6 +2010,29 @@ void ofono_gprs_add_context(struct ofono_gprs
> > *gprs,
> >
> > __ofono_atom_register(gc->atom, gprs_context_unregister);
> >
> > }
> >
> > +void ofono_gprs_bearer_notify(struct ofono_gprs *gprs,
> > + unsigned int cid, int bearer)
> > +{
> > + DBusConnection *conn = ofono_dbus_get_connection();
> > + GSList *l;
> > + const char *value = packet_bearer_to_string(bearer);
>
> Why bother running this operation before you're sure you're going to
> emit the signal?
Now that we're talking about network-initiated LTE bearers, I would rather be
safe than sorry. I wouldn't assume that the modem will signal the CPSB
(unchanged) value later in this case.
> Please move this down.
To avoid any race, we have to query the existing CPSB values after we enable
the CPSB subscription, right? We could surely move that to a later stage, but
I don't see the benefit.
--
Rémi Denis-Courmont
Nokia Devices R&D, Maemo Software, Helsinki
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
