Hi Martin,
On 01/10/2011 04:40 AM, [email protected] wrote:
> From: Martin Xu <[email protected]>
>
> ---
> gatchat/ppp_lcp.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
Can you please fix up your subject? It is simply too long. Make the
subject short and use the description field to describe the rest.
Do you have (or can you generate) a pppdump of this happening? What
protocol is RXJ- happening on? Does LCP layer accept our ACCM of 0 and
then later sends an RXJ-?
> diff --git a/gatchat/ppp_lcp.c b/gatchat/ppp_lcp.c
> index bc97257..181bc14 100644
> --- a/gatchat/ppp_lcp.c
> +++ b/gatchat/ppp_lcp.c
> @@ -106,7 +106,7 @@ static void lcp_generate_config_options(struct lcp_data
> *lcp)
> static void lcp_reset_config_options(struct lcp_data *lcp)
> {
> lcp->req_options = REQ_OPTION_ACCM;
> - lcp->accm = 0;
> + lcp->accm = ~0U;
>
Strictly speaking, RFC 1662 says this about the default ACCM:
"For other types of links, the default value is 0, since there is
no need for mapping."
In theory we fall into the 'other type' category.
> lcp_generate_config_options(lcp);
> }
> @@ -153,7 +153,7 @@ static void lcp_rca(struct pppcp_data *pppcp, const
> struct pppcp_packet *packet)
> * The Configuration Option is used to inform the peer which
> control
> * characters MUST remain mapped when the peer sends them.
> */
> - ppp_set_recv_accm(pppcp_get_ppp(pppcp), 0);
> + ppp_set_recv_accm(pppcp_get_ppp(pppcp), ~0U);
See my comment for the previous patch. This part should not be needed.
> break;
> default:
> break;
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
