Hi Remi,

>  src/common.c |   24 ++++++++++++++++++++++++
>  src/common.h |   13 +++++++++++++
>  2 files changed, 37 insertions(+), 0 deletions(-)
> 
> diff --git a/src/common.c b/src/common.c
> index d4e567b..c58ed5c 100644
> --- a/src/common.c
> +++ b/src/common.c
> @@ -714,6 +714,30 @@ const char *registration_tech_to_string(int tech)
>       }
>  }
>  
> +const char *packet_bearer_to_string(int bearer)
> +{
> +     switch (bearer) {
> +     case PACKET_BEARER_NONE:
> +             return "none";
> +     case PACKET_BEARER_GPRS:
> +             return "gprs";
> +     case PACKET_BEARER_EGPRS:
> +             return "egprs";
> +     case PACKET_BEARER_UMTS:
> +             return "umts";
> +     case PACKET_BEARER_HSUPA:
> +             return "hsupa";
> +     case PACKET_BEARER_HSDPA:
> +             return "hsdpa";
> +     case PACKET_BEARER_HSUPA_HSDPA:
> +             return "hspa";
> +     case PACKET_BEARER_EPS:
> +             return "eps";
> +     default:
> +             return "";
> +     }
> +}

these don't match the documentation. Use "edge" and "lte" for them.

And please don't use a default switch label. Just return "" at the end
of the function.

Regards

Marcel


_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reply via email to