Hi Remi,

>  src/modem.c |   13 ++++++-------
>  1 files changed, 6 insertions(+), 7 deletions(-)

patch has been applied.

However I added some paranoia protection for lock_owner reset to NULL. I
know that in theory it is protected via lockdown == TRUE, but that is an
issue bound to break something eventually.

> @@ -847,12 +850,8 @@ static DBusMessage *set_property_lockdown(struct 
> ofono_modem *modem,
>                                       OFONO_MODEM_INTERFACE,
>                                       "Powered", DBUS_TYPE_BOOLEAN,
>                                       &powered);
> -     } else {
> -             if (g_strcmp0(caller, modem->lock_owner))
> -                     return __ofono_error_access_denied(msg);
> -
> +     } else
>               lockdown_remove(modem);
> -     }
>  
>  done:
>       g_dbus_send_reply(conn, msg, DBUS_TYPE_INVALID);

And since this becomes a one line statement now and we already have a
goto label there, I changed this a bit around and removed the
unnecessary indentation.

Regards

Marcel


_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to