Hi Aki,

> > Just on a different thought here. The NETWORK_REGISTRATION_MODE_* is
> > local to src/network.c. We could just add the AUTO_ONLY mode there.
> >
> > The only downside I is see the already nasty init_registration_status
> > check, but that might be acceptable compared to crippling the string
> > conversion function.
> >
> > However at least the check would be clearly to just checking mode and
> > not mode + forced_mode.
> 
> I thought about this, but then we'd need more logic to when the user
> calls NetworkRegistration.Register() for automatic mode. That
> obviously can't change the mode. But perhaps this is now more
> manageable, since we got rid of Deregister(), which means there is
> just this one case to worry about.

can you have a stab at this and check how a patch would look like if we
just add another mode. If I am not mistaken we only have the extra code
in the init_registration_status. I could be wrong here since I have not
looked through that code in a long time.

Denis, any comments?

Regards

Marcel


_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to