Hi Mika,

On 02/07/2011 03:55 AM, [email protected] wrote:
> Hi Denis,
> 
> Thanks for the comments. 
> 
>>> +enum ofono_gprs_addrconf {
>>> +   OFONO_GPRS_ADDRCONF_NONE,
>>> +   OFONO_GPRS_ADDRCONF_STATIC,
>>> +   OFONO_GPRS_ADDRCONF_DHCP,
>>> +};
>>> +
>>
>> What exactly is the _NONE addrconf for?  And why don't we use 
>> a gboolean
>> here like before?
> 
> Neither "static" nor "DHCP" makes sense for IPv6. If we have an IPv6 only 
> context, the "Method" property will not show up at all.

What about combined V4 V6 contexts? What method do you use there, since
NONE doesn't exactly fit?  I'd rather see this be ignored for IPv6
contexts or that we separate the IPv4 and IPv6 configuration into two
separate batches.

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to