Hi Anand,

> Infineon modem selftest, during ifx_enable().
> Two steps trigger, with timeout. In case one fails, modem will not power up
> 
> ---
>  plugins/ifx.c |   66 +++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 64 insertions(+), 2 deletions(-)

patch has been applied, but I had to fix it up :(

> -     data->mux_init_timeout = g_timeout_add_seconds(5, mux_timeout_cb,
> +     /*
> +      * Total self test execution ... 2 seconds. Use
> +      * 10 seconds timeout to cover self tests and multiplexer setup.
> +      */
> +     data->mux_init_timeout = g_timeout_add_seconds(10, mux_timeout_cb,
>                                                               modem);

The ... in my review meant to keep the rest of the sentence. It needs to
be proper English so people can understand what it means.

I did fix this by myself since having v11 of this simple patch becomes a
little bit too ridiculous.

Regards

Marcel


_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to