Hi Andreas, 2011/2/16 Andreas WESTIN <andreas.wes...@stericsson.com>: >>> + if (!g_isi_modem_set_version(isimodem, modemversion)) >>> + return -EINVAL; >> >> I'm not going to add this API in GIsiModem. If we went this route, and >> used vendor quirks inside the isimodem driver, then it would make a >> whole lot more sense to do it in the driver create(), not here. >> >> But we're not going that route. Each driver detects the version of the >> ISI service it is talking to when it is probed. >> > > Yes this should not be there, but maybe I misunderstood you regarding the > version handling. I was under the impression that we checked the version we > get from doing PN_MTC or PN_MODEM_MCE ?
The modem driver is a bit of a special case again. There is no generic isimodem modem driver, but each modem plugin implements their own version. Here, just use PN_MODEM_MCE, since that is what the U8500 uses. Cheers, Aki _______________________________________________ ofono mailing list ofono@ofono.org http://lists.ofono.org/listinfo/ofono
