Hi Andrew,
ofono-boun...@ofono.org wrote:
> Hi Jeevaka,
>
> On 7 March 2011 16:35, Jeevaka Badrappan
> <jeevaka.badrap...@elektrobit.com> wrote:
>> ---
>> src/stkutil.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/src/stkutil.c b/src/stkutil.c index abd1c99..66b2924
>> 100644 --- a/src/stkutil.c
>> +++ b/src/stkutil.c
>> @@ -308,7 +308,7 @@ static gboolean parse_dataobj_alpha_id(struct
>> comprehension_tlv_iter *iter, char *utf8;
>>
>> len = comprehension_tlv_iter_get_length(iter); - if
>> (len == 0) { + if (len <= 1) {
>> *alpha_id = g_try_malloc0(1);
>
> In the description you talk about Length == 00 and no value
> part but this change affects the case of Length == 1, which I
> think we're handling correctly already. What is the exact problem
> case?
>
> I'm not sure but I think we already considered an identical
> patch, but in the spec there's nothing special about this
> case so I think the zero-length string needs to be sent to
> the user like any other string.
>
Agree, empty string case is already covered. Just confused myself.
Patch can be ignored as this is already covered.
Regards,
Jeevaka
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono
