Hi Denis, 2011/3/11 Denis Kenzior <[email protected]>: >> diff --git a/drivers/isimodem/sms.c b/drivers/isimodem/sms.c >> index 957b342..c90c06d 100644 >> --- a/drivers/isimodem/sms.c >> +++ b/drivers/isimodem/sms.c >> @@ -292,7 +292,7 @@ static void isi_sca_set(struct ofono_sms *sms, >> { &sd->params, sizeof(sd->params) }, >> }; >> >> - if (cbd == NULL || sd == NULL) >> + if (cbd == NULL || sd == NULL || sd->sim == NULL) > > The check for sd == NULL is too late since sd->params is being used up > above for initialization of iov...
That's right. However, the only way for sd == NULL would be that core first called remove() and then sca_set(), which should not happen. So I think I will just remove that check. Cheers, Aki _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
