Hi Jarko,

>>> +static gboolean gnss_parse_report(GAtResult *result, const char *prefix,
>>> +                                   const char **xml)
>>> +{
>>> +   GAtResultIter iter;
>>> +
>>> +   g_at_result_iter_init(&iter, result);
>>> +
>>> +   if (!g_at_result_iter_next(&iter, prefix))
>>> +           return FALSE;
>>> +
>>> +   if (!g_at_result_iter_next_unquoted_string(&iter, xml))
>>> +           return FALSE;
>>> +
>>> +   return TRUE;
>>
>> Do you really need a separate function?  This might belong in gnss_report
>>
> I just thought that it would be more logical to have separate function
> to parse the result rather than putting it all in to same function. Is
> that a big deal or do you want me to change that?

This is not really wrong, was just wondering.  Leave it as is for now.

Regards,
-Denis
_______________________________________________
ofono mailing list
ofono@ofono.org
http://lists.ofono.org/listinfo/ofono

Reply via email to