Hi Denis,
> >
> > - if ((data->sim_state == HUAWEI_SIM_STATE_VALID ||
> > - data->sim_state == HUAWEI_SIM_STATE_INVALID_CS) &&
> > - data->modem != NULL) {
> > + if (data->sim_state == HUAWEI_SIM_STATE_VALID ||
> > + data->sim_state == HUAWEI_SIM_STATE_INVALID_CS) {
>
> What are you trying to accomplish here? It sounds like you want to
> separate the logic of creating the NDIS gprs context (which does not
> depend on the modem port being available.) Is this the case? If so,
> then you need to submit this as a separate patch...
>
Yes. NDIS gprs context does not depend on the modem port. don't need
to check data->modem for it.
> > data->gprs = ofono_gprs_create(modem, OFONO_VENDOR_HUAWEI,
> > "atmodem", data->pcui);
> >
> > if (data->ndis == TRUE)
> > data->gc = ofono_gprs_context_create(modem, 0,
> > "huaweimodem", data->pcui);
> > - else
> > + else if (data->modem != NULL)
> > data->gc = ofono_gprs_context_create(modem, 0,
> > "atmodem", data->modem);
> >
>
> along with this chunk here, since they are not related to the issue
> you're trying to fix.
>
OK, I will sent a separate patch for this.
best regards
Caiwen
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
