Hi Amit,
On 06/08/2011 04:46 AM, Amit Mendapara wrote:
> Signed-off-by: Amit Mendapara <[email protected]>
> ---
> plugins/udev.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
Please remove the Signed-off-by line as we don't use it.
> diff --git a/plugins/udev.c b/plugins/udev.c
> index 0234fc0..4f4e6d8 100644
> --- a/plugins/udev.c
> +++ b/plugins/udev.c
> @@ -577,10 +577,10 @@ static void add_linktop(struct ofono_modem *modem,
>
> if (g_strcmp0(intfnum, "01") == 0) {
> devnode = udev_device_get_devnode(udev_device);
> - ofono_modem_set_string(modem, "Modem", devnode);
> + ofono_modem_set_string(modem, "ModemDevice", devnode);
> } else if (g_strcmp0(intfnum, "03") == 0) {
> devnode = udev_device_get_devnode(udev_device);
> - ofono_modem_set_string(modem, "Control", devnode);
> + ofono_modem_set_string(modem, "DataDevice", devnode);
>
> ofono_modem_set_integer(modem, "Registered", 1);
> ofono_modem_register(modem);
Rest looks fine to me.
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
