Hi Denis,

> > +   /* flash string is empty, it is allowed */
> > +   if (str == NULL)
> > +           return TRUE;
> 
> NULL strings are not valid here, they can't be sent over D-Bus.  Please
> omit this check.
> 

I will remove it.

> >     if (vc->driver->send_flash == NULL)
> >             return __ofono_error_not_implemented(msg);
> >
> > +   if (vc->status == CDMA_CALL_STATUS_DISCONNECTED)
> > +           return __ofono_error_failed(msg);
> > +
> 
> Just to double check, can a flash be sent during
> dialing/alerting/incoming stage?
> 

During dialing state, the flash should be ignored.

There is no alerting state used in CDMA voice call. It doesn't distinguish
alerting state and connected state.

There are two situations for incoming stage:
 (1) only one ringing call, the flash should be ignored
 (2) there is a waiting call. send flash will switch the calls.

To make it clearer, I will specified the valid states.

Please have a look the previous two patches relative call waiting and call
status notify. It is required to check call waiting status here. It depends on
those patches.

Thanks!

Caiwen
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to