Hi Marcel, On 01/11/2012 09:24 AM, Marcel Holtmann wrote: > Hi Denis, > >>>> + /* For obtain correct sms service number */ >>>> + g_at_chat_send(data->modem, "AT+CSCS=\"GSM\"", NULL, >>>> + NULL, NULL, NULL); >>> >>> you might better introduce a OFONO_VENDOR_SIM900 quirk and use that in >>> the SMS atom driver. The phonebook support will also end up overwriting >>> this one later on. So I am not even sure this works reliable this way. >>> Might be just pure luck with the order of the atom. >>> >> >> Actually this is fine assuming the modem does not support UTF-8 >> character set. The builtin assumption for most atoms is that CSCS is >> set to something sane before they're initialized. The phonebook driver >> will temporarily switch to UCS2 for the duration of the phonebook read >> and restore the previous setting. > > we did a vendor quirk for this for USSD of Qualcomm based modems. Maybe > we should then also move that into the modem plugins. >
Yes, I think that would be cleaner. I'll take care of it. Regards, -Denis _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
