Hi Frédéric, On 04/06/2012 08:17 AM, Frédéric Danis wrote: > Add ECNR (Echo Cancelation/Noise Reduction) and Inband Ringtone > capabilities to supported features (+BRSF event) > --- > src/emulator.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/src/emulator.c b/src/emulator.c > index e7c7d41..371e96c 100644 > --- a/src/emulator.c > +++ b/src/emulator.c > @@ -979,6 +979,8 @@ struct ofono_emulator *ofono_emulator_create(struct > ofono_modem *modem, > > em->type = type; > em->l_features |= HFP_AG_FEATURE_3WAY; > + em->l_features |= HFP_AG_FEATURE_ECNR; > + em->l_features |= HFP_AG_FEATURE_IN_BAND_RING_TONE; > em->l_features |= HFP_AG_FEATURE_REJECT_CALL; > em->l_features |= HFP_AG_FEATURE_ENHANCED_CALL_STATUS; > em->l_features |= HFP_AG_FEATURE_ENHANCED_CALL_CONTROL;
I think it would be better for the features to be modified based on what command handlers are registered. E.g. if NREC handler is registered in ofono_emulator_add_handler then add ECNR to local features, etc. Regards, -Denis _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
