Hi Denis,
> > @@ -232,12 +236,122 @@ static int speedup_disable(struct ofono_modem
> *modem)
> > g_at_chat_cancel_all(data->aux);
> > g_at_chat_unregister_all(data->aux);
> >
> > + /* Cleanup potential online enable polling */
> > + if (data->online_poll_source > 0) {
> > + g_source_remove(data->online_poll_source);
> > + data->online_poll_source = 0;
> > +
> > + g_free(data->online_cbd);
> > + data->online_cbd = NULL;
> > + }
> > +
>
> This looks fine, but it is actually in the wrong place. The core doesn't
> allow
> concurrent online and disable operations. This really belongs in
> speedup_remove so that you take care of the case where the modem is
> physically yanked out.
Ok, I see. In fact, I used Huawei plugin as example, so I will also fix it :)
Regards,
Bertrand
---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros
This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
