Hi Sebastien,
> src/mmsutil.c | 25 +++++++++++++++++++++++++
> src/mmsutil.h | 1 +
> 2 files changed, 26 insertions(+), 0 deletions(-)
>
> diff --git a/src/mmsutil.c b/src/mmsutil.c
> index c507d6f..725849b 100644
> --- a/src/mmsutil.c
> +++ b/src/mmsutil.c
> @@ -1661,3 +1661,28 @@ gboolean mms_message_encode(struct mms_message *msg,
> int fd)
>
> return FALSE;
> }
> +
> +char *mms_message_status_get_string(enum mms_message_status status)
> +{
> + char *status_str;
> +
> + switch (status) {
> + case MMS_MESSAGE_STATUS_DOWNLOADED:
> + status_str = "downloaded";
> + break;
> + case MMS_MESSAGE_STATUS_RECEIVED:
> + status_str = "received";
> + break;
> + case MMS_MESSAGE_STATUS_READ:
> + status_str = "read";
> + break;
> + case MMS_MESSAGE_STATUS_SENT:
> + status_str = "sent";
> + break;
> + case MMS_MESSAGE_STATUS_DRAFT:
> + status_str = "draft";
> + break;
> + }
> +
> + return status_str;
> +}
why bother with status_str here. Just call return right away. Also the
return value is const char *.
> diff --git a/src/mmsutil.h b/src/mmsutil.h
> index b2a0418..d3b507f 100644
> --- a/src/mmsutil.h
> +++ b/src/mmsutil.h
> @@ -146,3 +146,4 @@ gboolean mms_message_decode(const unsigned char *pdu,
> unsigned int len, struct mms_message *out);
> gboolean mms_message_encode(struct mms_message *msg, int fd);
> void mms_message_free(struct mms_message *msg);
> +char *mms_message_status_get_string(enum mms_message_status status);
Regards
Marcel
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
