Hi Christopher/August,
On 08/16/2012 02:37 AM, Christopher Vogl wrote:
From: August Mayer<[email protected]>
---
drivers/atmodem/sim.c | 61 +++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 61 insertions(+), 0 deletions(-)
Patch has been applied, however it had 3 trailing whitespace violations.
I had to edit it manually for it to apply.
Please configure your editor appropriately and add:
[apply]
whitespace = error
to your .git/config. It always doesn't hurt to test-apply your patches
before submission.
Also:
<snip>
+ enum ofono_sim_password_type pin_type =
ofono_sim_get_password_type(sim);
We still prefer C90 syntax for variable declarations, so I had to fix
this in a follow-on commit.
+ if (pin_type == OFONO_SIM_PASSWORD_NONE) {
+ DBG("Note: No password required, returning maximum retries:");
+ AT_PCT_SET_RETRIES(retries, OFONO_SIM_PASSWORD_SIM_PIN, 3);
+ AT_PCT_SET_RETRIES(retries, OFONO_SIM_PASSWORD_SIM_PIN2, 3);
+ AT_PCT_SET_RETRIES(retries, OFONO_SIM_PASSWORD_SIM_PUK, 10);
+ AT_PCT_SET_RETRIES(retries, OFONO_SIM_PASSWORD_SIM_PUK2, 10);
+ goto callback;
+ }
+
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono
