On Fri, 2010-05-28 at 07:34 -0700, Denis Kenzior wrote: > Hi Inaky, > > > From: Inaky Perez-Gonzalez <[email protected]> > > > > --- > > src/sms.c | 13 +++++++++++++ > > 1 files changed, 13 insertions(+), 0 deletions(-) > > > > Applied with s/D-BUS/D-Bus
Thank you for applying, but please *don't* do it like that. Complain and ask me to fix it, I'll be happy to comply and resend, but by modifying the commit yourself you drive git crazy and create conflicts between my commits and yours. Now I have to go for a time-consuming process of finding which ones are and working around it. You might have saved some of your time in doing that, but it is way less that the one I am going to use on resolving the mess on each commit *plus* I don't get to really learn / set on stone what your preferences are so these review round trips become less frequent in the long term. We both loose here. _______________________________________________ ofono mailing list [email protected] http://lists.ofono.org/listinfo/ofono
