Hi Philippe,

On 08/28/2012 08:21 AM, Philippe Nunes wrote:
---
  src/stkagent.c |   32 ++++++++++++++++++++++++++++++++
  src/stkagent.h |    5 +++++
  2 files changed, 37 insertions(+)


Patch has been applied, however...

diff --git a/src/stkagent.c b/src/stkagent.c
index 7c3f697..63b82f3 100644
--- a/src/stkagent.c
+++ b/src/stkagent.c
@@ -584,6 +584,38 @@ int stk_agent_request_digit(struct stk_agent *agent, const 
char *text,
        return 0;
  }

+int stk_agent_request_quick_digit(struct stk_agent *agent, const char *text,
+                               const struct stk_icon_id *icon,
+                               stk_agent_string_cb cb, void *user_data,
+                               ofono_destroy_func destroy, int timeout)

The indentation is not in line with the coding standard item M4. I amended this patch manually here and...

+{
+       DBusConnection *conn = ofono_dbus_get_connection();
+
+       agent->msg = dbus_message_new_method_call(agent->bus, agent->path,
+                                                       OFONO_SIM_APP_INTERFACE,
+                                                       "RequestQuickDigit");
+       if (agent->msg == NULL)
+               return -ENOMEM;
+
+       dbus_message_append_args(agent->msg,
+                                       DBUS_TYPE_STRING,&text,
+                                       DBUS_TYPE_BYTE,&icon->id,
+                                       DBUS_TYPE_INVALID);
+
+       if (dbus_connection_send_with_reply(conn, agent->msg,&agent->call,
+                                               timeout) == FALSE ||
+                       agent->call == NULL)
+               return -EIO;
+
+       agent->user_cb = cb;
+       agent->user_data = user_data;
+       agent->user_destroy = destroy;
+
+       dbus_pending_call_set_notify(agent->call, get_digit_cb, agent, NULL);
+
+       return 0;
+}
+
  static void get_key_cb(DBusPendingCall *call, void *data)
  {
        struct stk_agent *agent = data;
diff --git a/src/stkagent.h b/src/stkagent.h
index 6e267fc..f66f038 100644
--- a/src/stkagent.h
+++ b/src/stkagent.h
@@ -102,6 +102,11 @@ int stk_agent_request_digit(struct stk_agent *agent, const 
char *text,
                                stk_agent_string_cb cb, void *user_data,
                                ofono_destroy_func destroy, int timeout);

+int stk_agent_request_quick_digit(struct stk_agent *agent, const char *text,
+                               const struct stk_icon_id *icon,
+                               stk_agent_string_cb cb, void *user_data,
+                               ofono_destroy_func destroy, int timeout);
+

here

  int stk_agent_request_key(struct stk_agent *agent, const char *text,
                                const struct stk_icon_id *icon,
                                ofono_bool_t unicode_charset,

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
http://lists.ofono.org/listinfo/ofono

Reply via email to