Hi Denis/Johan: On Fri, Apr 19, 2013 at 12:24 PM, Denis Kenzior <[email protected]> wrote: > Hi Claudio, > > > On 04/19/2013 12:34 PM, Claudio Takahasi wrote: >> >> This patch adds echo canceling and noise reduction property to Handsfree >> interface, allowing the handsfree unit to enable or disable this feature >> in the audio gateway. >> >> According to Bluetooth HFP 1.6 spec: By default, if the AG supports its >> own embedded echo canceling and/or noise reduction functions, it shall >> have them activated until the AT+NREC command is received. >> --- >> doc/handsfree-api.txt | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/doc/handsfree-api.txt b/doc/handsfree-api.txt >> index 0b5d421..f877db0 100644 >> --- a/doc/handsfree-api.txt >> +++ b/doc/handsfree-api.txt >> @@ -56,6 +56,13 @@ Properties array{string} Features [readonly] >> to activate or deactivate the function from the >> HF, or >> the AG could autonomously initiate it. >> >> + boolean ECNR [readwrite] >> + >> + Boolean representing whether echo canceling and >> noise >> + reduction is enabled in the AG. This property may >> be >> + written to activate or deactivate this feature >> from >> + the HF unit. >> + > > > I really prefer we used full words instead of an acronym. You'll find we > have no acronyms in the oFono APIs.
The feature's name doesn't help, which name do you prefer? * EchoCancelingAndNoiseReduction * EchoNoise Any other suggestion? Regards, Claudio _______________________________________________ ofono mailing list [email protected] https://lists.ofono.org/mailman/listinfo/ofono
