On Wed, Dec 10, 2014 at 6:07 PM, Denis Kenzior <[email protected]> wrote:
>
> Hi Alfonso,
>
>
> On 12/09/2014 06:34 AM, Alfonso Sanchez-Beato wrote:
>
>> This patch series add the AvailableTechnologies property to the
>> RadioSettings interface. Its purpose is to show the list of valid
>> values for the TechnologyPreference property in the same interface.
>> The use case is letting a UI show the possible RATs so the user cannot
>> select an invalid value for a given modem.
>>
>> Alfonso Sanchez-Beato (4):
>>    doc: Add AvailableTechnologies property
>>    include: Add method to list RATs to radio-settings
>>    src: Implement RAT list property
>>    test: Add AvailableTechnologies to list-modems
>>
>>   doc/radio-settings-api.txt |  5 +++++
>>   include/radio-settings.h   | 15 +++++++++++++++
>>   src/radio-settings.c       | 47 ++++++++++++++++++++++++++++++
>> +++++++++++++++-
>>   test/list-modems           |  3 ++-
>>   4 files changed, 68 insertions(+), 2 deletions(-)
>>
>>
> I went ahead and applied all four patches.  However, I did tweak
> include/radio-settings.h and src/radio-settings.c afterwards.
>
> Mostly I changed radio_access_mode into a bit field and future-proofed the
> implementation some.  I think it is quite simpler now.
>
> As a bonus I added a minimalistic radio_settings driver to phonesim and
> caught one or two issues along the way.
>
> If I broke something, please let me know.
>

It worked fine with our driver, thanks. I've submitted a patch for a small
issue I found.

Br,
Alfonso
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to