LTE doesn't really use the concept of an attached state. However,
the oFono API needs it. ConnMan needs it as well.
---
 src/gprs.c | 36 ++++++++++++++++++++++++++----------
 1 file changed, 26 insertions(+), 10 deletions(-)

diff --git a/src/gprs.c b/src/gprs.c
index 9a85121..3acb412 100644
--- a/src/gprs.c
+++ b/src/gprs.c
@@ -1585,12 +1585,27 @@ static void release_active_contexts(struct ofono_gprs 
*gprs)
        }
 }
 
-static void gprs_attached_update(struct ofono_gprs *gprs)
+static void gprs_set_attached_property(struct ofono_gprs *gprs,
+                                       ofono_bool_t attached)
 {
-       DBusConnection *conn = ofono_dbus_get_connection();
        const char *path;
+       DBusConnection *conn = ofono_dbus_get_connection();
+       dbus_bool_t value = attached;
+
+       if (gprs->attached == attached)
+               return;
+
+       gprs->attached = attached;
+
+       path = __ofono_atom_get_path(gprs->atom);
+       ofono_dbus_signal_property_changed(conn, path,
+                               OFONO_CONNECTION_MANAGER_INTERFACE,
+                               "Attached", DBUS_TYPE_BOOLEAN, &value);
+}
+
+static void gprs_attached_update(struct ofono_gprs *gprs)
+{
        ofono_bool_t attached;
-       dbus_bool_t value;
 
        attached = gprs->driver_attached &&
                (gprs->status == NETWORK_REGISTRATION_STATUS_REGISTERED ||
@@ -1613,13 +1628,7 @@ static void gprs_attached_update(struct ofono_gprs *gprs)
                return;
        }
 
-       gprs->attached = attached;
-
-       path = __ofono_atom_get_path(gprs->atom);
-       value = attached;
-       ofono_dbus_signal_property_changed(conn, path,
-                               OFONO_CONNECTION_MANAGER_INTERFACE,
-                               "Attached", DBUS_TYPE_BOOLEAN, &value);
+       gprs_set_attached_property(gprs, attached);
 }
 
 static void registration_status_cb(const struct ofono_error *error,
@@ -1690,6 +1699,13 @@ static void gprs_netreg_update(struct ofono_gprs *gprs)
 
        DBG("attach: %u, driver_attached: %u", attach, gprs->driver_attached);
 
+       if (ofono_netreg_get_technology(gprs->netreg) ==
+                       ACCESS_TECHNOLOGY_EUTRAN) {
+               /* Ignore attach logic for LTE. There is no such concept. */
+               gprs_set_attached_property(gprs, attach);
+               return;
+       }
+
        if (gprs->driver_attached == attach)
                return;
 
-- 
2.5.5

_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to