Hi John,

<snip>

>>> -    g_queue_foreach(stk->envelope_q, (GFunc) g_free, NULL);
+    g_queue_foreach(stk->envelope_q, free_envelope_item, NULL);

Why not g_queue_free_full?
It would require a glib required version bump from 2.28 to 2.32, the
solution in the patch is 2.28 friendly. If it's ok to bump glib, I will
redo the patch to use g_queue_free_full instead.


Given than glib 2.32 is over 4 years old, I think it safe to do that.

Regards,
-Denis

_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to