Hi Lukasz,

On 03/30/2017 08:51 AM, Lukasz Nowak wrote:
From: Lukasz Nowak <[email protected]>

Create a unified callback_data structure, used for all timeout callbacks.
This allows to maintain a single callback_queue, which cancels any active
timeouts, and frees callback data memory when a usb device is hot unplugged.
---
 drivers/qmimodem/qmi.c | 401 ++++++++++++++++++++++---------------------------
 1 file changed, 180 insertions(+), 221 deletions(-)


I didn't like how invasive this approach was, and also the union was a bit ugly as it required all the weird data structures to be defined first. They were no longer local to actual functions that utilized them.

Please check [PATCH] qmi: Optimize structure allocations. That one should simplify things quite a bit as well. Not tested on my end, so please let me know / fix it if it is broken.

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to