Changes since v2:
* Revert callback data setup changes; the original model was fine so
  this amounted mostly to churn and, unfortunately, ended up introducing
  memory leaks
* Use ofono_gprs_context_deactivated in the detach_shutdown path instead
  of modifying release_active_contexts()
* Add support for roaming registration state

Original cover letter follows:

LTE is different from other 'GPRS' technologies in that a default bearer
always gets set up when the modem registers to the network.  Ofono has
some support for this and this series tries to set this up for QMI
modems.

The key to understanding this series is to understand that QMI modems
do not automatically enable the network interface when connecting to
an LTE network, even though the default bearer is already set up.  A
call to "start network" needs to be made in order to allow packets to
flow.  So the jist of this series is:

i) detect network registration to LTE network
ii) call ofono_gprs_cid_activated
iii) in read_settings, start by calling "start network"

...and then there are some other adjustments in the series to make
this all work.

I've tested this with my EC21, both on LTE and UMTS networks.  It
all seems to work, including moving out of network connectivity and
bringing the modem repeatedly online/offline.

One open question at this point:

* What happens if the connection manager calls deactivate_context
on the default bearer context?  I don't see that any other drivers
guard against this, and the QMI driver will happily stop the network
interface even though the default bearer is still up in the background.

Jonas Bonn (6):
  qmi: free cb_data on error
  qmi: implement detach_shutdown method
  qmi: activate default bearer context for LTE networks
  qim: use named status value
  qmi: stop listening to packet service notifications
  qmi: consolidate ss_info handling functions

 drivers/qmimodem/gprs-context.c         |  58 ++++++--------
 drivers/qmimodem/gprs.c                 | 135 ++++++++++++++++++++++++--------
 drivers/qmimodem/network-registration.c |  53 ++++++-------
 3 files changed, 146 insertions(+), 100 deletions(-)

-- 
2.9.3

_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to