Hi Alexander,
On 09/07/2017 02:23 PM, Alexander Couzens wrote:
There is no need to exclude it. It helps debugging because
the service is now logged.
---
drivers/qmimodem/qmi.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/qmimodem/qmi.c b/drivers/qmimodem/qmi.c
index 1af86aaccb08..7ea22992f8f0 100644
--- a/drivers/qmimodem/qmi.c
+++ b/drivers/qmimodem/qmi.c
@@ -1136,15 +1136,12 @@ static void discover_callback(uint16_t message,
uint16_t length,
if (type == QMI_SERVICE_CONTROL) {
device->control_major = major;
device->control_minor = minor;
- continue;
}
- list[count].type = type;
- list[count].major = major;
- list[count].minor = minor;
- list[count].name = name;
-
- count++;
+ list[i].type = type;
+ list[i].major = major;
+ list[i].minor = minor;
+ list[i].name = name;
We store the CONTROL service minor and major numbers and generally treat
it specially. If you care about logging it, why not just add an extra
debug statement?
if (name)
__debug_device(device, "found service [%s %d.%d]",
@@ -1154,6 +1151,8 @@ static void discover_callback(uint16_t message, uint16_t
length,
type, major, minor);
}
+ count = service_list->count;
+
ptr = tlv_get(buffer, length, 0x10, &len);
if (!ptr)
goto done;
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
