Hi Denis,
On Thu, 20 Sep 2018, 17:38 Denis Kenzior, <[email protected]> wrote:
> Hi Giacinto,
>
> On 09/19/2018 11:42 PM, Giacinto Cifelli wrote:
> > ---
> > src/gprs.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/src/gprs.c b/src/gprs.c
> > index 8f5d195..40f43e3 100644
> > --- a/src/gprs.c
> > +++ b/src/gprs.c
> > @@ -1642,6 +1642,9 @@ static void release_active_contexts(struct
> ofono_gprs *gprs)
> >
> > if (gc->driver->detach_shutdown != NULL)
> > gc->driver->detach_shutdown(gc, ctx->context.cid);
> > +
> > + /* Make sure the context is properly cleared */
> > + release_context(ctx);
> > }
> > }
> >
> > @@ -2241,6 +2244,7 @@ static DBusMessage
> *gprs_remove_context(DBusConnection *conn,
> > }
> >
> > DBG("Unregistering context: %s", ctx->path);
> > + release_context(ctx);
>
> If we get here then the context isn't active and doesn't need to be
> released. Active context release happens in gprs_deactivate_for_remove.
> So I don't think this is needed?
>
I got this change from external branches.
I doubted it was needed anymore, but couldn't be sure that I had tested all
cases.
thank you for checking it, and it can then be left out.
> > context_dbus_unregister(ctx);
> > gprs->contexts = g_slist_remove(gprs->contexts, ctx);
> >
> >
>
> Regards,
> -Denis
>
Regards,
Giacinto
>
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
