Hi Denis,

could you take this? It applies even only for the NONE auth_method, because
it just adds default to the switch/cases.
I am resubmitting the other 3.

BR,
Giacinto


On Thu, Sep 20, 2018 at 6:23 AM Giacinto Cifelli <[email protected]> wrote:

> this is needed so that with the additional methods NONE and ANY
> the compilation is not broken
> ---
>  drivers/atmodem/gprs-context.c   | 2 ++
>  drivers/mbimmodem/gprs-context.c | 2 ++
>  2 files changed, 4 insertions(+)
>
> diff --git a/drivers/atmodem/gprs-context.c
> b/drivers/atmodem/gprs-context.c
> index 79ac4c8..0585850 100644
> --- a/drivers/atmodem/gprs-context.c
> +++ b/drivers/atmodem/gprs-context.c
> @@ -304,6 +304,8 @@ static void at_gprs_activate_primary(struct
> ofono_gprs_context *gc,
>                                 snprintf(buf + len, sizeof(buf) - len - 3,
>                                                 ",\"PAP:%s\"", ctx->apn);
>                                 break;
> +                       default:
> +                               break;
>                         }
>                         break;
>                 default:
> diff --git a/drivers/mbimmodem/gprs-context.c
> b/drivers/mbimmodem/gprs-context.c
> index 79793c9..ce33b92 100644
> --- a/drivers/mbimmodem/gprs-context.c
> +++ b/drivers/mbimmodem/gprs-context.c
> @@ -75,6 +75,8 @@ static uint32_t auth_method_to_auth_protocol(enum
> ofono_gprs_auth_method method)
>                 return 2; /* MBIMAuthProtocolChap */
>         case OFONO_GPRS_AUTH_METHOD_PAP:
>                 return 1; /* MBIMAuthProtocolPap */
> +       default:
> +               return 0;
>         }
>
>         return 0;
> --
> 1.9.1
>
>
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to