Hi again Denis, On Sat, Sep 22, 2018 at 7:47 AM Giacinto Cifelli <[email protected]> wrote:
> Hi Denis, > > On Fri, Sep 21, 2018 at 6:12 PM Denis Kenzior <[email protected]> wrote: > >> Hi Giacinto, >> >> On 09/19/2018 10:50 PM, Giacinto Cifelli wrote: >> > --- >> > drivers/gemaltomodem/gemaltomodem.c | 2 + >> > drivers/gemaltomodem/gemaltomodem.h | 3 + >> > drivers/gemaltomodem/gprs-context-wwan.c | 446 >> +++++++++++++++++++++++++++++++ >> > 3 files changed, 451 insertions(+) >> > create mode 100644 drivers/gemaltomodem/gprs-context-wwan.c >> > >> > diff --git a/drivers/gemaltomodem/gemaltomodem.c >> b/drivers/gemaltomodem/gemaltomodem.c >> > index 614ca81..7afd3c1 100644 >> > --- a/drivers/gemaltomodem/gemaltomodem.c >> > +++ b/drivers/gemaltomodem/gemaltomodem.c > > > + >> > > +static gboolean gemalto_get_auth_command(struct ofono_modem *modem, int >> cid, >> > + enum ofono_gprs_auth_method auth_method, >> > + const char *username, const char >> *password, >> > + char *buf, guint buflen) >> > +{ >> > + int gto_auth = ofono_modem_get_integer(modem, "Gemalto_Auth"); >> >> Please use a CamelCase-d variable for this. E.g. GemaltoAuthType >> > > ok. This is new for this code, because I have always seen only variables > with underscores, but no problem. > Personally I would prefer camelCase 'gemaltoAuthType', because it is more > coherent in case of 1-part names like 'user', > but I'll do as you say. > On a second reading, I think you meant the "Gemalto_Auth" -> "GemaltoAuthType". I have renamed it, and also gto_auth -> gemalto_auth, clearer. >> Regards, >> -Denis >> > > Regards, > Giacinto > > Regards, Giacinto
_______________________________________________ ofono mailing list [email protected] https://lists.ofono.org/mailman/listinfo/ofono
