Hi Clement,
I ran a quick diff between this and sim900 driver and there's really not
enough differences to warrant a completely separate plugin. Can't we just
simply query the model version and act accordingly?
My opinion is that the sim800 driver is much to be needed as Simcom considers
the sim800 as the new sim900.
I "fear" that merging the two drivers will end up in a big file having a lot of
"if...else" for every different feature
between those two drivers. Whereas having the two separate for some time will
allow to address the use of sim800's new features
and support legacy sim900.
It might not be as bad as you think. Besides, if we determine at some
future date, that sim800 and sim900 are different enough to warrant
different drivers, then we have the option of splitting them out into
separate drivers at that time.
But as you are the maintainer, I think the decision is yours. Tell me and i'll
modify my patches accordingly then preventing too much noisy commits :)
My feeling is that we should merge these. The only difference I see
right now is a VENDOR flag tweak and an SMS Ready notification handling.
These don't amount to much and could be easily handled by the existing
driver.
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
