Hi Giacinto,
On 09/25/2018 08:20 AM, Giacinto Cifelli wrote:
---
src/gprs.c | 7 +++++++
1 file changed, 7 insertions(+)
I don't believe this patch is complete. It doesn't address certain
issues that arise from the introduction of this auth method. For
example, what happens if a context with:
AuthenticationMethod=Chap
Username=foo
Password=bar
gets AuthenticationMethod property set to 'None'? Do Username &
Password remain untouched? Are they changed to empty automatically?
What happens now to the drivers if such a context is activated? Some of
them can handle this because they only look at the presence of
Username/Password. But others will try to set authentication method to
None yet still append username / password...
What happens if
AuthenticationMethod=None and the client tries to set
Username to 'foo'? Is that an error? Success?
All of these issues need to be explained in your patch description...
Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
