Hi Anirudh,

On 09/28/2018 12:31 AM, Anirudh Gargi wrote:
EUTRAN SMS states mapped to registered and roaming respectively.
For the new CREG status (9/10) of CREG, it can be map to a new Dbus
CSFB property.

Added clarity in API doc for voice calling in case of lte.
---
  doc/network-api.txt |  4 +++-
  src/common.c        |  4 ++++
  src/common.h        | 19 +++++++++++++------
  3 files changed, 20 insertions(+), 7 deletions(-)


I split this patch into two and...

diff --git a/doc/network-api.txt b/doc/network-api.txt
index 83a2bc0..9c367c7 100644
--- a/doc/network-api.txt
+++ b/doc/network-api.txt
@@ -77,7 +77,9 @@ Properties    string Mode [readonly]
string Status [readonly] - The current registration status of a modem.
+                       The current registration status of a modem. In case
+                       technology is 'lte', 'registered' and 'roaming' may
+                       not necessarily mean voice calling available.
The possible values are:
                                "unregistered"  Not registered to any network
diff --git a/src/common.c b/src/common.c
index 3ccaf7c..0db412a 100644
--- a/src/common.c
+++ b/src/common.c
@@ -669,6 +669,10 @@ const char *registration_status_to_string(int status)
                return "unknown";
        case NETWORK_REGISTRATION_STATUS_ROAMING:
                return "roaming";
+       case NETWORK_REGISTRATION_STATUS_REGISTERED_SMS_EUTRAN:
+               return "registered";
+       case NETWORK_REGISTRATION_STATUS_ROAMING_SMS_EUTRAN:
+               return "roaming";
        }
return "";
diff --git a/src/common.h b/src/common.h
index 1b6b01d..f7bd3cb 100644
--- a/src/common.h
+++ b/src/common.h
@@ -37,12 +37,19 @@ enum access_technology {
/* 27.007 Section 7.2 <stat> */
  enum network_registration_status {
-       NETWORK_REGISTRATION_STATUS_NOT_REGISTERED =    0,
-       NETWORK_REGISTRATION_STATUS_REGISTERED =        1,
-       NETWORK_REGISTRATION_STATUS_SEARCHING =         2,
-       NETWORK_REGISTRATION_STATUS_DENIED =            3,
-       NETWORK_REGISTRATION_STATUS_UNKNOWN =           4,
-       NETWORK_REGISTRATION_STATUS_ROAMING =           5,
+       NETWORK_REGISTRATION_STATUS_NOT_REGISTERED =            0,
+       NETWORK_REGISTRATION_STATUS_REGISTERED =                1,
+       NETWORK_REGISTRATION_STATUS_SEARCHING =                 2,
+       NETWORK_REGISTRATION_STATUS_DENIED =                    3,
+       NETWORK_REGISTRATION_STATUS_UNKNOWN =                   4,
+       NETWORK_REGISTRATION_STATUS_ROAMING =                   5,
+       NETWORK_REGISTRATION_STATUS_REGISTERED_SMS_EUTRAN =     6,
+       NETWORK_REGISTRATION_STATUS_ROAMING_SMS_EUTRAN =        7,
+       /*
+        * Add along with new CSFB Dbus property.
+       NETWORK_REGISTRATION_STATUS_REGISTERED_NO_CSFB_EUTRAN = 9,
+       NETWORK_REGISTRATION_STATUS_ROAMING_NO_CSFB_EUTRAN =    10,
+       */

Took out this commented out block.

  };
/* 27.007 Section 7.3 <stat> */


Patches have been applied, thanks.

Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to