Hi, On Fri, Oct 12, 2018 at 9:44 AM Jonas Bonn <[email protected]> wrote: > > Hi, > > Pass --prefix="PATCH v2" and --cover-letter options to git-format-patch > in order to differentiate your patch submissions from each other.
thanks. I will re-submit with all this. > > > On 12/10/18 09:27, Giacinto Cifelli wrote: > > Co-authored-by: Martin Baschin <[email protected]> > > Tags go after description, and you've already got this down below anyway. yes, I have noticed too late, sorry. > > > > > The ofono_lte_default_attach_info is extended with protocol, > > authentication method, username and password. > > The transmission of this info from the src to the atom happens > > through the existing set_default_attach_info. > > A signal is emitted when one of these properties changes > > > > Co-authored-by: Martin Baschin <[email protected]> > > --- > > include/lte.h | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/include/lte.h b/include/lte.h > > index 0f2501c0..2f12ac29 100644 > > --- a/include/lte.h > > +++ b/include/lte.h > > @@ -3,6 +3,7 @@ > > * oFono - Open Source Telephony > > * > > * Copyright (C) 2016 Endocode AG. All rights reserved. > > + * Copyright (C) 2018 Gemalto M2M > > I wouldn't add a copyright line for a trivial change like this... > > > * > > * This program is free software; you can redistribute it and/or modify > > * it under the terms of the GNU General Public License version 2 as > > @@ -32,6 +33,10 @@ struct ofono_lte; > > > > struct ofono_lte_default_attach_info { > > char apn[OFONO_GPRS_MAX_APN_LENGTH + 1]; > > + enum ofono_gprs_proto proto; > > + enum ofono_gprs_auth_method auth_method; > > + char username[OFONO_GPRS_MAX_USERNAME_LENGTH + 1]; > > + char password[OFONO_GPRS_MAX_PASSWORD_LENGTH + 1]; > > }; > > > > typedef void (*ofono_lte_cb_t)(const struct ofono_error *error, void > > *data); > > /Jonas _______________________________________________ ofono mailing list [email protected] https://lists.ofono.org/mailman/listinfo/ofono
