Hi,
On Fri, Oct 12, 2018 at 10:25 AM Jonas Bonn <[email protected]> wrote:
>
> Wow... 45 minutes since your last submission and two minutes since I
> sent my last review email.  Impressive speed! ;)  Like I said, slow down...

yes, I think we were writing in parallel.

>
> Since I doubt any of my comments are incorporated here, I'll just wait
> for v3 before reading them again...
>
>
> On 12/10/18 10:14, Giacinto Cifelli wrote:
> > Second version of the lte atom, with selection of protocol and 
> > authentication.
> > In this version the settings are applied as soon as a property is changed.
>
> Include a long description here of what problem you are trying to solve
> and what approach you are using to solve that problem. Reading this
> description should be sufficient for me to be able to understand where
> the following sequence of patches is taking me.
>
> For follow-up versions, include a little section "Changes in v2" that
> tells me how v2 differs from the series v1 that I, possibly, have
> already reviewed.

ok. I will do all of this for the v3.

>
> /Jonas
>

Giacinto
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to