Hi Giacinto,
Given that, polluting atutil.c with vendor-specific code is not a great
idea. Even though you don't want to repeat the same code in lte.c and
gprs-context.c, it's not a big deal to do so, and the code is probably
easier to follow that way anyway.
What about introducing a vendor.c ?
I will mostly echo what Jonas already said. There should be no vendor
specific code in drivers/atmodem/atutil.c. The VENDOR tweaks are really
meant as just that. Tweaks to AT commands that were broken by the
vendor, or tweaks to behavior because the firmware says one thing but
really means another.
Once you get into a situation where you have an entirely different set
of AT commands being used, then you really need to consider using a
separate driver. Even if that means duplicating some code which is
generic 27.007. The generic 27.007 part can actually be put inside
atutil.c, so you can avoid (some) code duplication that way.
Regards,
-denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono
