On 17/10/18 10:52, Giacinto Cifelli wrote:

+
+static struct ofono_voicecall_driver driver = {
+     .name                   = "gemaltomodem",
+     .probe                  = gemalto_voicecall_probe,
+     .remove                 = gemalto_voicecall_remove,
+     .dial                   = gemalto_dial,
+     .answer                 = gemalto_answer,
+     .hangup_all             = gemalto_hangup_all,
+     .hangup_active          = gemalto_hangup,
+     .hold_all_active        = gemalto_hold_all_active,
+     .release_all_held       = gemalto_release_all_held,
+     .set_udub               = gemalto_set_udub,
+     .release_all_active     = gemalto_release_all_active,
+     .release_specific       = gemalto_release_specific,
+     .private_chat           = gemalto_private_chat,
+     .create_multiparty      = gemalto_create_multiparty,
+     .transfer               = gemalto_transfer,
+     .deflect                = NULL,
+     .swap_without_accept    = NULL,
Are other drivers explicit about _not_ providing implementations? I'd
drop these otherwise?

again, it is done so in the original drivers/atmodem/voicecall.c.
I would drop them...
I would like to know why they weren't dropped in atmodem in the first
place, before dropping them.
Either solution is ok for me, I just want some clarification.

Make the declaration 'const' while you're at it.

/Jonas
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to