Hi Denis,

On 17/10/18 17:03, Denis Kenzior wrote:
Hi Jonas,

On 10/17/2018 05:23 AM, Jonas Bonn wrote:
There are a large number of files in the tree that define _GNU_SOURCE
despite not actually using features hidden behind this flag.  This patch
removes all these definitions in one fell swoop...
---

I realize that it's not quite kosher in ofono to send pathes that touch
more than directory.  Breaking this up into separate patches doesn't
really make sense though, given its nature.  If the list insists,
though, I can break this up into a series of ~50 patches...


Yes, fair enough.  But:

drivers/mbimmodem/mbim.c: In function ‘receive_header’:
drivers/mbimmodem/mbim.c:423:16: error: implicit declaration of function ‘TEMP_FAILURE_RETRY’ [-Werror=implicit-function-declaration]
   ssize_t len = TEMP_FAILURE_RETRY(read(fd,
                 ^~~~~~~~~~~~~~~~~~


tools/tty-redirector.c: In function ‘accept_handler’:
tools/tty-redirector.c:249:8: error: implicit declaration of function ‘accept4’; did you mean ‘accept’? [-Werror=implicit-function-declaration]
   nfd = accept4(fd, (struct sockaddr *) &addr, &addrlen, SOCK_CLOEXEC);
         ^~~~~~~
         accept



Right.  mbim and tools are not in my configuration...

Anyway, I was nice and fixed these for you.  It compiles cleanly for me and I applied this patch.


Thanks.  Good of you!

/Jonas


Regards,
-Denis
_______________________________________________
ofono mailing list
[email protected]
https://lists.ofono.org/mailman/listinfo/ofono

Reply via email to