Hi,
On Tue, Oct 23, 2018 at 10:29 AM Jonas Bonn <jo...@norrbonn.se> wrote:
>
> Hi,
>
> On 23/10/18 10:21, Giacinto Cifelli wrote:
> > ---
> > drivers/atmodem/sms.c | 12 +++++++++++-
> > 1 file changed, 11 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/atmodem/sms.c b/drivers/atmodem/sms.c
> > index 7638885e..380cd763 100644
> > --- a/drivers/atmodem/sms.c
> > +++ b/drivers/atmodem/sms.c
> > @@ -858,8 +858,18 @@ static gboolean build_cnmi_string(char *buf, int
> > *cnmi_opts,
> > data->cnma_enabled ? "21" : "1",
> > FALSE))
> > return FALSE;
> >
> > + switch (data->vendor) {
> > + case OFONO_VENDOR_GEMALTO:
> > + mode = "0";
> > + break;
> > + default:
> > + /* Sounds like 2 is the sanest mode */
>
> This particular comment doesn't add anything useful so just drop it.
Not mine... I didn't want my patch rejected because I changed 2 things
at the same time (add vendor and remove comment).
>From the choice of word (sane), I think this comment is from Denis.
without even checking with git blame.
>
> /Jonas
Giacinto
_______________________________________________
ofono mailing list
ofono@ofono.org
https://lists.ofono.org/mailman/listinfo/ofono
